Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Change GrpcServer to grpcServer #3442

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented Jun 10, 2022

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@Liuhaai Liuhaai requested a review from a team as a code owner June 10, 2022 23:25
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3442 (3f2bc83) into master (fbd9bc4) will decrease coverage by 75.19%.
The diff coverage is n/a.

❗ Current head 3f2bc83 differs from pull request most recent head 173629a. Consider uploading reports for the commit 173629a to get more accurate results

@@            Coverage Diff             @@
##           master   #3442       +/-   ##
==========================================
- Coverage   75.19%       0   -75.20%     
==========================================
  Files         236       0      -236     
  Lines       22024       0    -22024     
==========================================
- Hits        16562       0    -16562     
+ Misses       4573       0     -4573     
+ Partials      889       0      -889     
Impacted Files Coverage Δ
api/serverV2.go
action/stake_restake.go
db/kvstore_impl.go
gasstation/gasstattion.go
api/blocklistener.go
blockchain/block/systemlog.go
blockchain/filedao/filedao_util.go
action/protocol/vote/unproductivedelegate.go
actpool/options.go
blockchain/block/footer.go
... and 226 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd9bc4...173629a. Read the comment docs.

@dustinxie dustinxie merged commit 26d543f into iotexproject:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants