Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] Build hdwallet delete command line into new ioctl #3487

Merged
merged 8 commits into from
Jul 5, 2022

Conversation

LuckyPigeon
Copy link
Contributor

Description

Refactor hdwalledelete command in new ioctl, with the following note.

  • Use client interface to construct the Cobra command.
  • Output package is deprecated, replace it with errors package.
  • Replace fmt.Println with cmd.Println
  • Refactor unit test to cover the modification.

Fixes #3284

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • TestNewHdwalletCreateCmd

Test Configuration:

  • Firmware version: Ubuntu 21.04
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@LuckyPigeon
Copy link
Contributor Author

This PR will continue after #3470 merged.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #3487 (348f3a1) into master (c75411c) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##           master    #3487   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files         244      245    +1     
  Lines       22681    22699   +18     
=======================================
+ Hits        17105    17119   +14     
- Misses       4650     4655    +5     
+ Partials      926      925    -1     
Impacted Files Coverage Δ
ioctl/client.go 73.29% <0.00%> (-0.93%) ⬇️
ioctl/newcmd/hdwallet/hdwalletdelete.go 100.00% <100.00%> (ø)
consensus/scheme/rolldpos/rolldposctx.go 73.65% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75411c...348f3a1. Read the comment docs.

@LuckyPigeon LuckyPigeon marked this pull request as ready for review June 30, 2022 16:10
@LuckyPigeon LuckyPigeon requested a review from a team as a code owner June 30, 2022 16:10
@Liuhaai Liuhaai merged commit 91fd545 into iotexproject:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ioctl] build hdwallet delete command line into new ioctl
3 participants