-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] move config.ActPool to actpool package refactor #3514
Conversation
require.NoError(t, err) | ||
pp, err := poll.NewGovernanceChainCommitteeProtocol( | ||
nil, | ||
committee, | ||
uint64(123456), | ||
func(uint64) (time.Time, error) { return time.Now(), nil }, | ||
cfg.Chain.PollInitialCandidatesInterval, | ||
bcf.PollInitialCandidatesInterval, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directly use blockchain.DefaultConfig.PollInitialCandidatesInterval
here, no need to define bcf
config/config_test.go
Outdated
@@ -312,7 +313,7 @@ func TestValidateActPool(t *testing.T) { | |||
} | |||
|
|||
func TestValidateMinGasPrice(t *testing.T) { | |||
ap := ActPool{MinGasPriceStr: Default.ActPool.MinGasPriceStr} | |||
ap := actpool.Config{MinGasPriceStr: Default.ActPool.MinGasPriceStr} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this test to actpool
package
action/protocol/poll/protocol.go
Outdated
"github.com/iotexproject/iotex-core/pkg/log" | ||
"github.com/iotexproject/iotex-core/state" | ||
) | ||
|
||
const ( | ||
_protocolID = "poll" | ||
// RollDPoSScheme means randomized delegated proof of stake | ||
RollDPoSScheme = "ROLLDPOS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_rollDPoSScheme
no need to export
Codecov Report
@@ Coverage Diff @@
## master #3514 +/- ##
==========================================
- Coverage 75.43% 74.54% -0.89%
==========================================
Files 247 251 +4
Lines 22845 23117 +272
==========================================
Hits 17233 17233
- Misses 4685 4957 +272
Partials 927 927
Continue to review full report at Codecov.
|
The changes on |
If no change here, will get an "import cycle not allowed" error on build |
* upstream/master: (28 commits) [ioctl] Incorrect conversion between integer types (iotexproject#3522) [action] fix incorrect conversion between integer types (iotexproject#3545) [test] fix TestLoadBlockchainfromDB (iotexproject#3521) [ioctl] correct Chinese usage message (iotexproject#3510) fix err not hanled (iotexproject#3509) add ReadHeaderTimeout (iotexproject#3539) [iotcl] Reset config cmd (iotexproject#3496) Update gosec.yaml Update ci.yaml Update analysis.yaml Delete gosec.yaml.bak Create gosec.yaml [config] move config.ActPool to actpool package refactor (iotexproject#3514) Update ci.yaml Update analysis.yaml Update analysis.yaml [config] move config.Chain to blockchain package (iotexproject#3511) remove circleci (iotexproject#3498) [ioctl] Build block bucketlist command line into new ioctl (iotexproject#3469) [config] remove EVMNetworkID() and SetEVMNetworkID() (iotexproject#3503) ...
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3513
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: