[action] nil point check in candidate_statereader #3633

huof6829 · 2022-09-08T12:36:37Z

Description

Fixes #(issue)

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov · 2022-09-08T12:46:18Z

Codecov Report

Merging #3633 (e026ff2) into master (a20e489) will decrease coverage by 0.81%.
The diff coverage is 75.45%.

@@            Coverage Diff             @@
##           master    #3633      +/-   ##
==========================================
- Coverage   75.43%   74.62%   -0.82%     
==========================================
  Files         247      264      +17     
  Lines       22845    23686     +841     
==========================================
+ Hits        17233    17675     +442     
- Misses       4685     5092     +407     
+ Partials      927      919       -8

Impacted Files	Coverage Δ
action/action_deserializer.go	`57.14% <ø> (ø)`
action/protocol/poll/nativestaking.go	`41.08% <0.00%> (-0.65%)`	⬇️
action/protocol/poll/staking_command.go	`10.71% <0.00%> (ø)`
action/protocol/staking/read_state.go	`15.38% <0.00%> (ø)`
action/protocol/vote/probationlist.go	`87.50% <ø> (ø)`
api/blocklistener.go	`70.73% <0.00%> (ø)`
api/websocket.go	`5.17% <0.00%> (-0.19%)`	⬇️
blockchain/block/block_deserializer.go	`71.15% <ø> (ø)`
blockchain/blockchain.go	`0.89% <0.00%> (ø)`
blockchain/filedao/filedao_legacy.go	`85.80% <ø> (ø)`
... and 114 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dustinxie · 2022-09-09T17:04:59Z

action/protocol/staking/candidate_statereader.go

@@ -402,7 +402,7 @@ func (c *candSR) readStateBucketsByVoter(ctx context.Context, req *iotexapi.Read

 func (c *candSR) readStateBucketsByCandidate(ctx context.Context, req *iotexapi.ReadStakingDataRequest_VoteBucketsByCandidate) (*iotextypes.VoteBucketList, uint64, error) {
 cand := c.GetCandidateByName(req.GetCandName())
- if c == nil {
+ if cand == nil {
