fix read tip tool bug #3662

CoderZhi · 2022-10-13T03:22:35Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov · 2022-10-13T03:31:14Z

Codecov Report

Merging #3662 (18a9b79) into master (263ff82) will increase coverage by 0.06%.
The diff coverage is 90.69%.

❗ Current head 18a9b79 differs from pull request most recent head b124d26. Consider uploading reports for the commit b124d26 to get more accurate results

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
+ Coverage   74.47%   74.53%   +0.06%     
==========================================
  Files         269      274       +5     
  Lines       23925    24048     +123     
==========================================
+ Hits        17818    17925     +107     
- Misses       5174     5184      +10     
- Partials      933      939       +6

Impacted Files	Coverage Δ
action/protocol/staking/handlers.go	`74.47% <33.33%> (-0.64%)`	⬇️
ioctl/newcmd/did/didgenerate.go	`83.67% <83.67%> (ø)`
ioctl/newcmd/action/actionread.go	`100.00% <100.00%> (ø)`
ioctl/newcmd/action/actionsendraw.go	`100.00% <100.00%> (ø)`
ioctl/newcmd/did/diddoc.go	`100.00% <100.00%> (ø)`
ioctl/newcmd/did/didregister.go	`100.00% <100.00%> (ø)`
ioctl/newcmd/did/didupdate.go	`100.00% <100.00%> (ø)`
action/protocol/staking/candidate_center_extra.go	`0.00% <0.00%> (-13.56%)`	⬇️
action/protocol/staking/protocol.go	`59.62% <0.00%> (+0.63%)`	⬆️
ioctl/newcmd/action/action.go	`90.04% <0.00%> (+0.95%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dustinxie · 2022-10-14T15:51:50Z

tools/readtip/main.go

+func readStateDBPath() string {
+ if _stateDBPath != "" {
+ return _stateDBPath
+ }
 cfg, err := config.New([]string{_overwritePath, _secretPath}, []string{})


nit: instead of return statedb path, can return the cfg?

cfg, err := stateDBPathConfig()

then directly use it in main()

store, err := db.CreateKVStore(cfg.DB, cfg.Chain.TrieDBPath)