[staking] Cannot Unstake if Bucket is Endorsed #4134
Conversation
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4134 +/- ##
==========================================
+ Coverage 75.38% 76.38% +1.00%
==========================================
Files 303 340 +37
Lines 25923 28973 +3050
==========================================
+ Hits 19541 22132 +2591
- Misses 5360 5733 +373
- Partials 1022 1108 +86 ☔ View full report in Codecov by Sentry. |
| @@ -175,6 +175,10 @@ func (p *Protocol) handleUnstake(ctx context.Context, act *action.Unstake, csm C | |||
| failureStatus: iotextypes.ReceiptStatus_ErrUnstakeBeforeMaturity, | |||
| } | |||
| } | |||
| if rErr := validateBucketEndorsement(NewEndorsementStateManager(csm.SM()), bucket, false, blkCtx.BlockHeight); rErr != nil { | |||
| return log, rErr | |||
There was a problem hiding this comment.
in func validateBucketEndorsement(
case errors.Is(err, state.ErrStateNotExist):
if isEndorsed {
return &handleError{
err: errors.New("bucket is not endorsed"),
failureStatus: iotextypes.ReceiptStatus_ErrInvalidBucketType,
}
}
should return
err: errors.New("bucket is not an endorse bucket"),
failureStatus: iotextypes.ReceiptStatus_ErrInvalidBucketIndex,
since the bucket is not an endorse bucket
There was a problem hiding this comment.
and then if it returns this error, it should be fine to continue?
There was a problem hiding this comment.
returning error means validation failed, should not continue
| @@ -96,7 +96,7 @@ func validateBucketEndorsement(esm *EndorsementStateManager, bucket *VoteBucket, | |||
| case errors.Is(err, state.ErrStateNotExist): | |||
| if isEndorsed { | |||
| return &handleError{ | |||
| err: errors.New("bucket is not endorsed"), | |||
| err: errors.New("bucket is not an endorse bucket"), | |||
There was a problem hiding this comment.
The error here is the same as the error on line 86 above, and it is best to distinguish it
|
Description
After delegate endorsement introduced, we cannot unstake bucket if it's a endorse bucket.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: