Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in worker.Reset() #4159

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix bug in worker.Reset() #4159

merged 2 commits into from
Mar 4, 2024

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented Mar 3, 2024

Description

the nonce of queue whose account is a fresh legacy one isn't updated by PendingNonceConsideringFreshAccount() after UseZeroNonceForFreshAccount is activated. Therefore, the pending nonce of the account is reset to 1 while it's supposed to be 0 when minting a block

Fixes #4156

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 76.39%. Comparing base (e1f0636) to head (0a22f15).
Report is 178 commits behind head on master.

Files Patch % Lines
actpool/queueworker.go 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4159      +/-   ##
==========================================
+ Coverage   75.38%   76.39%   +1.01%     
==========================================
  Files         303      339      +36     
  Lines       25923    28873    +2950     
==========================================
+ Hits        19541    22057    +2516     
- Misses       5360     5716     +356     
- Partials     1022     1100      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Liuhaai Liuhaai merged commit 7cb9a1c into iotexproject:master Mar 4, 2024
2 of 5 checks passed
dustinxie pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some wallets have inccorect nonce from rpc.
3 participants