Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[context] enable delegate endorsement and refactor fresh account conversion at Tsunami height #4188

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dustinxie
Copy link
Member

…ersion at Tsunami height

Description

as title.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@@ -220,7 +220,7 @@ func (d *IotxDispatcher) actionHandler() {
case a := <-d.actionChan:
d.handleActionMsg(a)
case <-d.quit:
log.L().Info("action handler is terminated.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this log is tooooooo long, make debug not convenient

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.07%. Comparing base (e1f0636) to head (e9d8a95).
Report is 204 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
+ Coverage   75.38%   76.07%   +0.69%     
==========================================
  Files         303      340      +37     
  Lines       25923    29241    +3318     
==========================================
+ Hits        19541    22246    +2705     
- Misses       5360     5888     +528     
- Partials     1022     1107      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dustinxie dustinxie merged commit 6ae8cf8 into master Mar 15, 2024
4 of 6 checks passed
@dustinxie dustinxie deleted the tsunami branch March 15, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants