[ioctl] Add CandidateEndorsement and CandidateActivate action #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4194 +/- ##
==========================================
+ Coverage 75.38% 76.76% +1.38%
==========================================
Files 303 340 +37
Lines 25923 29269 +3346
==========================================
+ Hits 19541 22469 +2928
- Misses 5360 5695 +335
- Partials 1022 1105 +83 ☔ View full report in Codecov by Sentry. |
CoderZhi
approved these changes
Mar 22, 2024
dustinxie
reviewed
Apr 1, 2024
ioctl/cmd/action/stake2endorse.go
Outdated
|
|
||
| _stake2EndorseCmdShorts = map[config.Language]string{ | ||
| config.English: "Endorse bucket's candidate on IoTeX blockchain", | ||
| config.Chinese: "在 IoTeX 区块链上给质押票的候选人背书", |
There was a problem hiding this comment.
nit:
在 IoTeX 区块链上背书候选人
在 IoTeX 区块链上撤销背书
this is more clear and straightforward?
dustinxie
reviewed
Apr 1, 2024
ioctl/cmd/action/stake2register.go
Outdated
| @@ -20,12 +20,12 @@ import ( | |||
| var ( | |||
| _registerCmdUses = map[config.Language]string{ | |||
| config.English: "register NAME (ALIAS|OPERATOR_ADDRESS) (ALIAS|REWARD_ADDRESS) (ALIAS|OWNER_ADDRESS) AMOUNT_IOTX STAKE_DURATION [DATA] [--auto-stake] [-s SIGNER] [-n NONCE] [-l GAS_LIMIT] [-p GAS_PRICE] [-P PASSWORD] [-y]", | |||
| config.Chinese: "register 名字 (别名|操作者地址）（别名|奖励地址）（别名|所有者地址）IOTX数量 质押持续时间 [数据] [--auto-stake] [-s 签署人] [-n NONCE] [-l GAS限制] [-p GAS价格] [-P 密码] [-y]", | |||
| config.Chinese: "register 名字 (别名 | 操作者地址）（别名 | 奖励地址）（别名 | 所有者地址）IOTX 数量 质押持续时间 [数据] [--auto-stake] [-s 签署人] [-n NONCE] [-l GAS 限制] [-p GAS 价格] [-P 密码] [-y]", | |||
There was a problem hiding this comment.
auto-formated by ide, reverted
dustinxie
reviewed
Apr 1, 2024
ioctl/cmd/action/stake2register.go
Outdated
| } | ||
|
|
||
| _registerCmdShorts = map[config.Language]string{ | ||
| config.English: "Register a candidate", | ||
| config.Chinese: "在IoTeX区块链上注册候选人", | ||
| config.Chinese: "在 IoTeX 区块链上注册候选人", |
dustinxie
reviewed
Apr 2, 2024
| @@ -27,11 +27,11 @@ var ( | |||
|
|
|||
| _stake2EndorseCmdShorts = map[config.Language]string{ | |||
| config.English: "Endorse bucket's candidate on IoTeX blockchain", | |||
| config.Chinese: "在 IoTeX 区块链上给质押票的候选人背书", | |||
| config.Chinese: "在 IoTeX 区块链上背书候选人", | |||
dustinxie
reviewed
Apr 2, 2024
| } | ||
| _stake2UnEndorseCmdShorts = map[config.Language]string{ | ||
| config.English: "UnEndorse bucket's candidate on IoTeX blockchain", | ||
| config.Chinese: "在 IoTeX 区块链上给质押票的背书进行撤销", | ||
| config.Chinese: "在 IoTeX 区块链上撤销背书", |
dustinxie
approved these changes
Apr 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4191
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: