Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl][ioid][#1] ioid sub commands #4284

Merged
merged 10 commits into from
May 30, 2024
Merged

Conversation

saitofun
Copy link
Contributor

Description

ioid sub commands:

  1. apply ioid ioctl ioid apply
  2. set device contract address ioctl ioid device
  3. register ioid project ioctl ioid register
  4. query ioid project ioctl ioid project

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • make test

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (cc526cd) to head (846d1bd).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4284      +/-   ##
==========================================
+ Coverage   77.02%   77.04%   +0.01%     
==========================================
  Files         342      345       +3     
  Lines       29406    29644     +238     
==========================================
+ Hits        22651    22840     +189     
- Misses       5650     5684      +34     
- Partials     1105     1120      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saitofun saitofun merged commit d4ab547 into master May 30, 2024
3 of 5 checks passed
@saitofun saitofun deleted the feat/ioid_contract_interaction branch May 30, 2024 08:08
dustinxie pushed a commit that referenced this pull request May 30, 2024
* feat(ioctl/ioid): ioctl support ioid interactions

* chore: remove redundent abis

* fix: transfer amount flag type change to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants