Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2etest] add tests for original actions after candidate ownership transfer #4295

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Jun 7, 2024

Description

The pr introduce e2etest framework to simplify add test cases, focusing on construct actions and expectations.
Futhermore, add testcases via the frameworks for original action handlings after candidate ownership transfer.

based on #4294

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested review from CoderZhi, dustinxie, Liuhaai and a team as code owners June 7, 2024 13:43
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 47.94521% with 38 lines in your changes missing coverage. Please review.

Project coverage is 76.69%. Comparing base (cc526cd) to head (b63aadf).
Report is 31 commits behind head on master.

Current head b63aadf differs from pull request most recent head 991bbab

Please upload reports for the commit 991bbab to get more accurate results.

Files Patch % Lines
action/signedaction.go 50.00% 24 Missing and 11 partials ⚠️
action/protocol/staking/protocol.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4295      +/-   ##
==========================================
- Coverage   77.02%   76.69%   -0.34%     
==========================================
  Files         342      352      +10     
  Lines       29406    29310      -96     
==========================================
- Hits        22651    22479     -172     
- Misses       5650     5727      +77     
+ Partials     1105     1104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dustinxie dustinxie merged commit 1009b32 into iotexproject:master Jun 12, 2024
2 of 3 checks passed
@envestcc envestcc deleted the ownershiptest branch June 12, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants