Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staking] enable new staking index #4305

Merged
merged 14 commits into from
Jun 18, 2024
Merged

[staking] enable new staking index #4305

merged 14 commits into from
Jun 18, 2024

Conversation

envestcc
Copy link
Member

Description

This pr introduce new staking indexer for staking protocol, which include two mainly changes:

  • can retrive new staking contract buckets by staking api
  • new staking contract votes for candidate

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested review from CoderZhi, dustinxie, Liuhaai and a team as code owners June 17, 2024 03:06
@envestcc envestcc mentioned this pull request Jun 17, 2024
1 task
chainservice/builder.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix unit tests

action/protocol/staking/protocol.go Outdated Show resolved Hide resolved
blockchain/config.go Outdated Show resolved Hide resolved
chainservice/builder.go Outdated Show resolved Hide resolved
chainservice/builder.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@envestcc envestcc merged commit ebcc20c into master Jun 18, 2024
2 of 3 checks passed
@envestcc envestcc deleted the enable-new-stakeindex branch June 18, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants