Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ls #15

Merged
merged 5 commits into from
Nov 30, 2015
Merged

feat/ls #15

merged 5 commits into from
Nov 30, 2015

Conversation

daviddias
Copy link
Member

#8

@daviddias daviddias mentioned this pull request Nov 30, 2015
Closed
dignifiedquire
dignifiedquire reviewed Nov 30, 2015
View reviewed changes
commands/ls.js
var apiCtl = ipfsAPI('/ip4/127.0.0.1/tcp/5001')
apiCtl.files.ls('/npm-registry', function (err, res) {
if (err) {
return console.log(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not console.error?

@daviddias
Copy link
Member Author

thank you for CR @dignifiedquire :D

daviddias added a commit that referenced this pull request Nov 30, 2015
@daviddias
Merge pull request #15 from diasdavid/feat/ls
e09d88e 
feat/ls
@daviddias daviddias merged commit e09d88e into master Nov 30, 2015
@daviddias daviddias deleted the feat/ls branch November 30, 2015 16:02
@dignifiedquire
Copy link
Member

@diasdavid always happy to tell you what you did wrong 😝

@daviddias daviddias mentioned this pull request Nov 30, 2015
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @dignifiedquire