Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

preparations for js-ipfs 0.36 #39

Merged
merged 3 commits into from
May 22, 2019
Merged

preparations for js-ipfs 0.36 #39

merged 3 commits into from
May 22, 2019

Conversation

olizilla
Copy link
Member

@olizilla olizilla commented May 22, 2019

run the CI tests with [email protected]

of note, I'm seeing test failures locally on master as well as with
the latest ipfs 0.36 rc, so I'm sharing this PR to trigger CI to
see if it's just an issue on my machine.

see: ipfs/js-ipfs#2024

run the CI tests with [email protected]

of note, I'm seeing test failures locally on master as well as with
the latest ipfs 0.36 rc, so I'm sharing this PR to trigger CI to
see if it's just an issue on my machine.

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@olizilla
Copy link
Member Author

@alanshaw of note the tests are not passing for service-worker-gateway on 0.36.0-rc.0, but they are aren't passing on master with 0.35.0 today either.

@olizilla
Copy link
Member Author

it's just timeouts trying to fetch remote content so far, so may be caused by network conditions beyond the tests.

@olizilla
Copy link
Member Author

@vasco-santos do you have a moment to take a look at why the tests aren't passing?

@olizilla
Copy link
Member Author

olizilla commented May 22, 2019

hmm it looks like just bumping the timeouts up is the answer... which isn't great news.
nope, spoke to soon, bunping it locally to 150000ms didn't help.

@vasco-santos
Copy link
Member

@olizilla thanks for putting this together, I will have a look!

@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files           4        4           
  Lines          76       76           
=======================================
  Hits           61       61           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e2c9f...2b17ca2. Read the comment docs.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good now. The ipfs-http-response module needed to be updated as well, in order to provide the correct data do the service-worker-gateway

@vasco-santos vasco-santos merged commit 0a16bf5 into master May 22, 2019
@vasco-santos vasco-santos deleted the ipfs-0.36 branch May 22, 2019 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants