Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ipld-prime v0.7.0 #145

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented Jan 21, 2021

Goals

Upgrade to latest tagged go-ipld-prime to stay current with developments there

Implementation

Update go-ipld-prime and go-ipld-prime-proto

  • regenerate test chain ipld prime nodes
  • Fix a couple renames (ReprKind is now Kind)
  • Ints in ipld-prime are now int64, so fix a few type conversions

upgrade to latest go-ipld-prime and make needed type conversions
Copy link
Member

@warpfork warpfork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@acruikshank acruikshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Little troubled by how much generated code is coming in here. Looks like its mostly go-lacks-generics workaround code, so I guess it's ok.

@hannahhoward
Copy link
Collaborator Author

@acruikshank the generated code is a fact of life for optimized go-ipld-prime nodes at some point we should bring you up to speed on the design goals of schema generation -- maybe we can setup a chat with @warpfork at some point to get you two acquainted.

@hannahhoward hannahhoward merged commit 90b4d16 into master Jan 22, 2021
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
@mvdan mvdan deleted the feat/update-go-ipld-prime-v0.7.0 branch December 15, 2021 14:16
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
* fix: better error message on complete

* fix: on complete error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants