Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Unix Sockets #4218

Closed
cbluth opened this issue Sep 7, 2017 · 5 comments · Fixed by #6678
Closed

Support Unix Sockets #4218

cbluth opened this issue Sep 7, 2017 · 5 comments · Fixed by #6678
Labels
topic/api Topic api

Comments

@cbluth
Copy link

cbluth commented Sep 7, 2017 •
edited
Loading

Version information:

go-ipfs version: 0.4.10-
Repo version: 5
System version: amd64/linux
Golang version: go1.8.3
root@23b28683cdc7:/#

Type:

Feature

Severity:

Low/Medium

Description:

Please consider supporting the option to bind the ipfs/http-gateway and/or the API to a unix socket instead of (or in addition to) a TCP socket.
@magik6k
Copy link
Member

magik6k commented Sep 7, 2017

There is some discussion on unix sockets in ipfs/notes#129. This is probably also blocked by #3856

@Stebalien Stebalien mentioned this issue Nov 30, 2017
Open
@whyrusleeping
Copy link
Member

cc @keks this is something we want to be able to do with the ipfs cmds lib

@whyrusleeping whyrusleeping added the topic/api Topic api label Dec 4, 2017
@keks
Copy link
Contributor

keks commented Dec 6, 2017

Yes! That would be rad.

I think the best way would be to make a wire format that works directly on top of a reliable transport, so it doesn't matter whether we use unix domain sockets or e.g. websockets (which have been requested in the past).
I'm working on getting cmds1.0 out as soon as I can. Afterwards I'll tackle this one.

@keks keks mentioned this issue Dec 6, 2017
Open
@kyledrake
Copy link

Not to add more work to everyone's plates, but unix socket support for go-ipfs would be great, and I would definitely use it in production.

@Stebalien Stebalien mentioned this issue May 1, 2019
Closed
Stebalien added a commit that referenced this issue Sep 26, 2019
@Stebalien
daemon: support unix domain sockets for the API/gateway
e2a0631 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes #4218
@Stebalien Stebalien mentioned this issue Sep 26, 2019
Merged
Stebalien added a commit that referenced this issue Sep 26, 2019
@Stebalien
daemon: support unix domain sockets for the API/gateway
2d10961 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes #4218
Stebalien added a commit that referenced this issue Sep 27, 2019
@Stebalien
daemon: support unix domain sockets for the API/gateway
a8b7375 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes #4218
Stebalien added a commit that referenced this issue Oct 1, 2019
@Stebalien
daemon: support unix domain sockets for the API/gateway
460c211 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes #4218
@ghost
Copy link

ghost commented Oct 1, 2019

Nice work!

ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
daemon: support unix domain sockets for the API/gateway
f7db189 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes ipfs#4218
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
daemon: support unix domain sockets for the API/gateway
6fddf33 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes ipfs#4218
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
daemon: support unix domain sockets for the API/gateway
76c43fd 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes ipfs#4218
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
daemon: support unix domain sockets for the API/gateway
3d40f75 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes ipfs#4218
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
daemon: support unix domain sockets for the API/gateway
b5e083a 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes ipfs#4218
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
daemon: support unix domain sockets for the API/gateway
7911711 
All the work was client-side. Unix domain socket multiaddrs already worked
server-side.

fixes ipfs#4218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/api Topic api
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

daemon: support unix domain sockets for the API/gateway ipfs/kubo
5 participants
@kyledrake @keks @whyrusleeping @magik6k @cbluth