Disambiguate online/offline naming in sharness tests #8254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
commented
Jul 8, 2021
schomatis
force-pushed
the
schomatis/chore/sharness/t0250/change-online-offline-naming
branch
from
55a56e8
to
9561068
Compare
lidel
approved these changes
Jul 9, 2021
aschmahmann
deleted the
schomatis/chore/sharness/t0250/change-online-offline-naming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In connection with #8131.
Does not have any change in logic, just naming. The commits should be reviewed separately; we can drop the second one if too invasive.
Do not use online/offline naming system when starting the daemon in tests but the more specific "with network".
Particularly in the files tests (
t0250) the online/offline names were also being used to signal if the daemon was running or not. They were even used what appears to be incorrectly as"online"meant"no-daemon"(now renamed as such) so the internal logic oftests_for_files_apishould be reviewed (left aFIXMEnote for that).