Fix: Use a pointer type on IpfsNode.Peering #8331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Ah, lol. So, peering works right now because we're passing PeerWith. This causes us to create a peering service even though the peering service on the main struct is empty.
I was really confused how our sharness tests were passing.
|
Thanks! |
|
Yes. At the moment the setting of the peering service on daemon cannot be changed after startup, so I guess the sharness test did not reveal the problem. |
|
Yep. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The current type of
IpfsNode.PeeringisPeeringService.It is different from the type
*PeeringServicereturned fromnode.Peeringprovided in core/node/groups.go:270 .This difference prevents fx from injecting
IpfsNode.Peering.The current
node.PeeringServiceon the daemon is a zero value.I also cannot get the valid
PeeringServiceonSwarmAddCommandin #8147 due to this problem.Proposal
I propose to fix the type of
IpfsNode.PeeringServicefromPeeringServiceto*PeeringService.