Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

stop using peer.IDFromString #37

Closed
marten-seemann opened this issue Aug 19, 2022 · 2 comments · Fixed by #38
Closed

stop using peer.IDFromString #37

marten-seemann opened this issue Aug 19, 2022 · 2 comments · Fixed by #38
Labels
need/triage Needs initial labeling and prioritization

Comments

@marten-seemann
Copy link
Member

peer.IDFromString was removed from libp2p, as it is almost always used incorrectly, see libp2p/go-libp2p-core#274.

This repo uses it in

pid, err := peer.IDFromString(pidString)

I'm not 100% sure if it's used correctly here or not, so I can't submit a fix. This needs to be resolved before we can update the IPFS stack to go-libp2p v0.22.0.

@marten-seemann marten-seemann added the need/triage Needs initial labeling and prioritization label Aug 19, 2022
@welcome

This comment was marked as resolved.

@lidel
Copy link
Member

lidel commented Aug 19, 2022

I believe the pidString is binary:

So we want peer.IDFromBytes([]byte(pidString)) here. Mind opening a fix @marten-seemann?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants