Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify global zap logger With labels #104

Closed
lanzafame opened this issue Feb 25, 2021 · 0 comments · Fixed by #105
Closed

Add ability to specify global zap logger With labels #104

lanzafame opened this issue Feb 25, 2021 · 0 comments · Fixed by #105
Labels
need/triage Needs initial labeling and prioritization

Comments

@lanzafame
Copy link
Contributor

My thoughts on how this would work are as follows, there would be a GOLOG_LOG_LABELS env var that takes a comma-separated list of key-value pairs, i.e. GOLOG_LOG_LABELS="app,example_app,dc,sjc-1" this env var would be processed in configFromEnv function along with other env var which would allow for all dependencies of the top-level application to receive these labels.

@lanzafame lanzafame added the need/triage Needs initial labeling and prioritization label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant