Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk: allow the visitor to return an error #60

Open
schomatis opened this issue Feb 4, 2021 · 1 comment
Open

Walk: allow the visitor to return an error #60

schomatis opened this issue Feb 4, 2021 · 1 comment
Labels
need/triage Needs initial labeling and prioritization

Comments

@schomatis
Copy link
Contributor

go-merkledag/merkledag.go

Lines 376 to 377 in bf51443

// WalkGraph will walk the dag in order (depth first) starting at the given root.
func Walk(ctx context.Context, getLinks GetLinks, c cid.Cid, visit func(cid.Cid) bool, options ...WalkOption) error {

Only the logic in GetLinks is allowed to but not visit.

@schomatis schomatis added the need/triage Needs initial labeling and prioritization label Feb 4, 2021
@welcome
Copy link

welcome bot commented Feb 4, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant