Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add gateway conformance tests #314

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

achingbrain
Copy link
Member

Skips practically all of them to just get the framework in place.

I'm not sure all the tests are valid, the spec is missing large chunks of functionality asserted in the tests, but the assertions don't necessarily assert IETF/W3c spec compliant behaviour, for example: ipfs/gateway-conformance#217

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Skips practically all of them to just get the framework in place.

I'm not sure all the tests are valid, the spec is missing large
chunks of functionality asserted in the tests, but the assertions
don't necessarily assert IETF/W3c spec compliant behaviour, for
example: ipfs/gateway-conformance#217
@achingbrain achingbrain merged commit 8268872 into main Jul 10, 2024
4 checks passed
@achingbrain achingbrain deleted the test/add-gateway-compliance-tests branch July 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant