fix: use blockstore interface where possible #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of depending on the Helia `Blocks` interface, depend on `Blockstore` as none of the extra methods are used. This improves compatibility with other modules and allows reuse from non-Helia contexts.
SgtPooki
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
code changes look fine.
Q: Are we sure we don't want an abstraction layer? I get the type benefits for now, but future extensibility could be hindered by not having an abstraction layer?
counterpoint: I can't think of how we would want to extend the blockstore other than your sessionBlockstore.
Perhaps, but YAGNI and all that. We can re-evaluate if requirements change in the future. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of depending on the Helia
Blocksinterface, depend onBlockstoreas none of the extra methods are used.This improves compatibility with other modules and allows reuse from non-Helia contexts.