Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add doc-check script and export types used by functions #637

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

achingbrain
Copy link
Member

Uses tsc to attempt to compile any typescript code blocks in markdown files to ensure our examples don't get out of date.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Uses tsc to attempt to compile any `typescript` code blocks in
markdown files to ensure our examples don't get out of date.
@achingbrain achingbrain requested a review from a team as a code owner September 21, 2024 06:23
@achingbrain
Copy link
Member Author

Needs another push or two to fix up the out of date examples.

@achingbrain achingbrain marked this pull request as draft September 21, 2024 06:24
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm

@achingbrain achingbrain marked this pull request as ready for review September 23, 2024 06:27
@achingbrain achingbrain changed the title fix: add doc-check script fix: add doc-check script and export types used by functions Sep 23, 2024
@achingbrain achingbrain merged commit 4f14996 into main Sep 23, 2024
18 checks passed
@achingbrain achingbrain deleted the chore/add-doc-check branch September 23, 2024 06:27
@achingbrain achingbrain mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants