Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

chore: update tests to async await #87

Merged
merged 5 commits into from
Nov 8, 2019
Merged

chore: update tests to async await #87

merged 5 commits into from
Nov 8, 2019

Conversation

PedroMiguelSS
Copy link
Contributor

@PedroMiguelSS PedroMiguelSS commented Sep 30, 2019 •
edited
Loading

This PR changes all the tests to use async/await.
It completes phase number 4 to tackle #87 as referenced here.

@PedroMiguelSS PedroMiguelSS mentioned this pull request Sep 30, 2019
Closed
@PedroMiguelSS PedroMiguelSS force-pushed the chore/update-tests-to-async-await branch 2 times, most recently from ce990bd to c147efd Compare October 2, 2019 11:15
@PedroMiguelSS PedroMiguelSS changed the base branch from master to chore/update-ipfsd-ctl October 7, 2019 09:21
@hugomrdias
Copy link
Member

CI still red and conflicts can you fix this so we can review ?

@alanshaw alanshaw mentioned this pull request Oct 7, 2019
Closed
vasco-santos
vasco-santos suggested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a first pass through this

package.json Show resolved Hide resolved
test/exchange-files.js Outdated Show resolved Hide resolved
test/files.js Outdated Show resolved Hide resolved
test/utils/wait-for.js Outdated Show resolved Hide resolved
test/ipns-pubsub.js Show resolved Hide resolved
test/ipns-pubsub.js Outdated Show resolved Hide resolved
test/ipns-pubsub.js Outdated Show resolved Hide resolved
test/ipns-pubsub.js Show resolved Hide resolved
test/utils/circuit.js Outdated Show resolved Hide resolved
test/pubsub.js Outdated Show resolved Hide resolved
achingbrain
achingbrain suggested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, great work - let's get this in.

test/exchange-files.js Outdated Show resolved Hide resolved
test/files.js Outdated Show resolved Hide resolved
test/files.js Outdated Show resolved Hide resolved
test/files.js Outdated Show resolved Hide resolved
test/files.js Outdated Show resolved Hide resolved
test/ipns-pubsub.js Outdated Show resolved Hide resolved
test/ipns-pubsub.js Outdated Show resolved Hide resolved
test/ipns-pubsub.js Outdated Show resolved Hide resolved
test/utils/wait-for.js Outdated Show resolved Hide resolved
test/utils/p-retry.js Show resolved Hide resolved
@PedroMiguelSS PedroMiguelSS force-pushed the chore/update-tests-to-async-await branch from c147efd to 159246d Compare October 25, 2019 12:10
@PedroMiguelSS PedroMiguelSS changed the base branch from chore/update-ipfsd-ctl to master October 25, 2019 12:12
@PedroMiguelSS
Copy link
Contributor Author

I've committed the requested changes. Can you review it again, please? @achingbrain @vasco-santos

@achingbrain
Copy link
Member

This is great - so nearly there. Two final, final things:

  1. Remove the package-lock.json file
  2. Create a /src/utils/chai.js file that configures the two chai plugins, export expect from that (similar to these lines) and use that export everywhere - this is so chai is only configured in one place - if plugins are added later by someone else somewhere else it'll cause the same problem

@PedroMiguelSS
Copy link
Contributor Author

Done @achingbrain!

@PedroMiguelSS PedroMiguelSS mentioned this pull request Nov 5, 2019
Merged
@daviddias
Copy link
Member

@PedroMiguelSS see error's on CI: https://travis-ci.com/ipfs/interop/jobs/250668939#L329-L372 can you figure out why it is failing?

@achingbrain achingbrain merged commit 27beca5 into master Nov 8, 2019
@achingbrain achingbrain deleted the chore/update-tests-to-async-await branch November 8, 2019 16:01
@alanshaw
Copy link
Member

🎉👏❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain requested changes

@vasco-santos vasco-santos vasco-santos requested changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PedroMiguelSS @hugomrdias @achingbrain @daviddias @alanshaw @vasco-santos