Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammatical change required in Help Text #1460

Closed
davenes8148 opened this issue Apr 23, 2020 · 1 comment · Fixed by #1465
Closed

Grammatical change required in Help Text #1460

davenes8148 opened this issue Apr 23, 2020 · 1 comment · Fixed by #1465
Assignees
@jessicaschilling
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-content Content design, writing, information architecture

Comments

@davenes8148
Copy link

Describe the bug
When you are viewing the Connection Status page of the help text the following sentence isn't grammatically correct:
"You can configure your node to with a custom API address too."

If it said "You can configure your node with a custom API address too." then it would be much easier to read.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Status page.
  2. Click on the Help text Icon.
  3. Click next and move to page 2.
  4. Read the Text.

Expected behavior
The sentence "You can configure your node to with a custom API address too." needs to the first to be removed.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 (Laptop)
@jessicaschilling
Copy link
Contributor

@davenes8148 -- thanks for finding this! Would you be interested in making a PR to fix?

@hacdias hacdias transferred this issue from ipfs/ipfs-desktop Apr 24, 2020
@hacdias hacdias added exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-content Content design, writing, information architecture labels Apr 24, 2020
jessicaschilling added a commit that referenced this issue Apr 24, 2020
@jessicaschilling
Grammar error from #1460
677013b
@jessicaschilling jessicaschilling self-assigned this Apr 24, 2020
@jessicaschilling jessicaschilling mentioned this issue Apr 24, 2020
Merged
lidel pushed a commit that referenced this issue Apr 27, 2020
@jessicaschilling
Miscellaneous help text fixes (#1465)
25d3d9a 
- Closes #1460: grammar error in helptext
- Closes #1461: Continue to learn more -> Click "Next" to learn more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-content Content design, writing, information architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Miscellaneous help text fixes ipfs/ipfs-webui
3 participants
@jessicaschilling @hacdias @davenes8148