-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/webrtc-direct listener breaks Status page #2176
Labels
effort/days
Estimated to take multiple days, but less than a week
exp/expert
Having worked on the specific codebase is important
kind/bug
A bug in existing code (including security flaws)
P1
High: Likely tackled by core team if no one steps up
Comments
lidel
added
kind/bug
A bug in existing code (including security flaws)
P1
High: Likely tackled by core team if no one steps up
need/triage
Needs initial labeling and prioritization
labels
Nov 9, 2023
Better repro steps: $ # shut down local node (if you have it)
$ go install github.com/ipfs/kubo/cmd/[email protected] # use latest binary
$ export IPFS_PATH=/tmp/test-webrtc # use empty profile
$ ipfs init
...
initializing IPFS node at /tmp/test-webrtc
$ ipfs config Swarm.Transports.Network.WebRTCDirect --json true
$ ipfs config Addresses.Swarm --json '["/ip4/0.0.0.0/udp/4002/webrtc-direct"]'
$ ipfs daemon
...
WebUI: http://127.0.0.1:5001/webui Opening WebUI at http://127.0.0.1:5001/webui should produce screenshot I described, clicking on Advanced will reveal empty addresses: |
This was referenced Nov 29, 2023
1 task
whizzzkid
added
exp/expert
Having worked on the specific codebase is important
effort/days
Estimated to take multiple days, but less than a week
and removed
need/triage
Needs initial labeling and prioritization
labels
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort/days
Estimated to take multiple days, but less than a week
exp/expert
Having worked on the specific codebase is important
kind/bug
A bug in existing code (including security flaws)
P1
High: Likely tackled by core team if no one steps up
Describe the bug
This is the same problems as #2033 but for
/webrtc-direct
To Reproduce
"/ip4/0.0.0.0/udp/4002/webrtc-direct"
toAddresses.Swarm
ipfs config Swarm.Transports.Network.WebRTCDirect --json true
See Release Notes for more info: https:/ipfs/kubo/blob/master/docs/changelogs/v0.24.md
Expected behavior
Show
/webrtc-direct
(spec) listeners returned byipfs.id
While at it, also make sure
/webrtc
(spec) is supported as well (not in kubo yet, but will be added in near future).To avoid a big refactor, a fix similar to
patches/multiaddr+8.1.2.patch
from #2057 would be sufficient for solving the problem at hand.Add codes for
webrtc-direct
andwebrtc
https:/multiformats/multiaddr/blob/master/protocols.csvThe text was updated successfully, but these errors were encountered: