Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: console error when no API available #1443

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix: console error when no API available #1443

merged 1 commit into from
Jul 16, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 18, 2020 •
edited
Loading

This PR removes error in console when there is no API available:

error-when-down-2020-04-18--01-56-26

@lidel lidel marked this pull request as ready for review April 28, 2020 10:17
rafaelramalho19
rafaelramalho19 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@rafaelramalho19 rafaelramalho19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if you don't change to my suggestion is still good 😄

@rafaelramalho19 rafaelramalho19 merged commit 2f39b61 into master Jul 16, 2020
@rafaelramalho19 rafaelramalho19 deleted the fix/console-error-on-no-api branch July 16, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelramalho19 rafaelramalho19 rafaelramalho19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidel @rafaelramalho19