Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self-ref files page link in "no files" screen #1531

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Remove self-ref files page link in "no files" screen #1531

merged 1 commit into from
Jul 15, 2020

Conversation

jessicaschilling
Copy link
Contributor

  • Removes the files screen's "manage files" link to itself when displaying no-files-here welcome text
  • Changes "You can drag and drop ..." to "Drag and drop here ..."
  • Fixes an it's/its typo

Closes #1530

@jessicaschilling jessicaschilling mentioned this pull request Jun 25, 2020
Closed
@jessicaschilling
Copy link
Contributor Author

@lidel, do you mind taking a look?

rafaelramalho19
rafaelramalho19 reviewed Jul 2, 2020
View reviewed changes
src/files/info-boxes/welcome-info/WelcomeInfo.js
</Trans>
<Trans i18nKey='welcomeInfo.paragraph2' t={t}>
<p className='f5'>Easily <a href='#/files' className='link blue b'>manage files</a> in your IPFS repo. You can drag and drop to add files, move and rename them, delete, share or download them.</p>
<p className='f5'>Easily manage files in your IPFS repo. Drag and drop here to add files, move and rename them, delete, share or download them.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't need HTML manipulated translations, you can replace all of these with

<p className='f5'>{ t('welcomeInfo.paragraph2') }</p>

But if you want to keep consistency with the rest of the page, I don't mind 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it as is – can be refactored in separate PR.

lidel
lidel approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ok to merge @rafaelramalho19

@rafaelramalho19 rafaelramalho19 merged commit 1289a38 into master Jul 15, 2020
@rafaelramalho19 rafaelramalho19 deleted the bug/nofiles-pagelink branch July 15, 2020 15:18
This was referenced Aug 20, 2022
Open
Open
@internetbuilder internetbuilder mentioned this pull request Oct 23, 2022
Open
@xaiksan1 xaiksan1 mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@rafaelramalho19 rafaelramalho19 rafaelramalho19 left review comments

Assignees

@lidel lidel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files: bogus link in onboarding materials
3 participants
@jessicaschilling @lidel @rafaelramalho19