Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch multiaddrs from /ipfs/Qm to /p2p/Qm #1564

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

bertrandfalguiere
Copy link
Contributor

No description provided.

@jessicaschilling
Copy link
Contributor

@lidel, can you please have a look?

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @bertrandfalguiere, thank you!

Context:

Libp2p is replacing all multiaddrs of the form /ipfs/QmFoo (old-style) with /p2p/QmFoo (new-style). The /ipfs prefix his an historical artifact from the days before libp2p was split out of IPFS.
libp2p/libp2p#79 (comment)

@lidel lidel changed the title /ipfs/Qm multiaddresses are now /p2p/Qm... refactor: switch multiaddrs from /ipfs/Qm to /p2p/Qm Jul 28, 2020
@lidel lidel merged commit cf28d12 into ipfs:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants