chore: consolidate repeat-use i18n keys #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidel and @rafaelramalho19 -- I'd appreciate a review at your leisure. This isn't terribly urgent work, but wanted to get this PR in sooner rather than later to avoid merge conflicts. Thank you! |
|
note to self: enable preload of |
Actions: add, edit, reset, saving Status: connectedToIpfs, couldNotConnect Terms: address, addresses, advanced, agent, connection, downSpeed, example, gateway, latency, location, rateIn, rateOut, size, totalIn, totalOut, unknown, upSpeed
Actions: OK, browse, clear, create, noThanks, download, more, moreInfo, pinVerb, rename, unpin, selectAll, unselectAll Status: connectingToIpfs Terms: blocks, file, files, folder, folders, publicKey, node, pinNoun, name, pins, repo
jessicaschilling
force-pushed
the
chore/consolidate-common-i18n
branch
from
1fd2e27
to
35b8812
Compare
|
Rebased from master to account for this morning's merges, and cleaned up two additional duplicate keys. @lidel and @rafaelramalho19, this is ready for your review - thank you! |
lidel
approved these changes
Sep 4, 2020
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves repeat-use i18n keys into
app.json, explicitly references that namespace as needed in the appropriate files, and cleans up a few related details. This work enables more of a standardized, taxonomy-style approach as we continue to enhance functionality in Web UI overall.Closes #1600.
Details
The
app.jsonfile now includes i18n key categories for repeat-use items:actions(things that are likely to appear on buttons and similar):addbrowsecancelchangeclearclosecopycreatedeletedownloadeditimportmoremoreInfonoThanksOKpinVerb(to distinguish between that andterms.pinNounwhen languages differ)renameresetsavesavingselectAllsubmitunpinunselectAllnav(things that appear in navigation furniture):bugsLinkcodeLinkrevisionstatus(repeat-instance global status messages):connectedToIpfsconnectingToIpfscouldNotConnectterms(either IPFS terms of art, or extremely common words in the Web UI context):addressaddressesadvancedagentapiapiAddressblocksconnectiondownSpeedexamplefilefilesfolderfoldersgatewayinlatencylocationnamenodeoutpeerpeerIdpeerspinNoun(to distinguish between that andactions.pinVerbwhen languages differ)pinspublicKeyrateInrateOutreposizetotalIntotalOutunknownupSpeedtour(previously existed, but didn't contain complete list of keys):backclosefinishnextskiptooltip