Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add success notification on "set pinning" action #2038

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

xrazis
Copy link
Contributor

@xrazis xrazis commented Sep 29, 2022

Adds pin/unpin notification for local node and service providers as described in #1979 . I'm not quite sure if i should edit the locales/en file directly, @SgtPooki let me know if there any changes that should be made.

Examples:

Local provider pin:

image

Service provider unpin:

image

@xrazis xrazis requested a review from a team as a code owner September 29, 2022 13:28
@xrazis xrazis temporarily deployed to Deploy September 29, 2022 13:34 Inactive
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine to me. waiting for CI

@SgtPooki
Copy link
Member

SgtPooki commented Oct 4, 2022

This is awesome @xrazis , thanks so much =)

@SgtPooki SgtPooki temporarily deployed to Deploy October 4, 2022 23:08 Inactive
@hacdias hacdias changed the title #1979 Add success notification on "set pinning" action feat: add success notification on "set pinning" action Oct 5, 2022
@hacdias hacdias merged commit e410164 into ipfs:main Oct 5, 2022
@xrazis xrazis deleted the feat/add-notification-on-pin branch October 5, 2022 09:33
ipfs-gui-bot pushed a commit that referenced this pull request Nov 9, 2022
## [2.20.0](v2.19.0...v2.20.0) (2022-11-09)

 CID `bafybeibjbq3tmmy7wuihhhwvbladjsd3gx3kfjepxzkq6wylik6wc3whzy`

 ---

### Features

* add success notification on "set pinning" action ([#2038](#2038)) ([e410164](e410164))
* track remote pins in progress ([#1919](#1919)) ([d3a6524](d3a6524))
* update to ipfs-geoip v9 ([#2061](#2061)) ([546fb5a](546fb5a))

### Bug Fixes

*  /webtransport breaks status page ([#2057](#2057)) ([ea89e7f](ea89e7f)), closes [#2033](#2033)

### Trivial Changes

* pull new translations ([#2049](#2049)) ([f6062b2](f6062b2))
* pull new translations ([#2056](#2056)) ([e13ff17](e13ff17))
* pull new translations ([#2059](#2059)) ([0bb5bf3](0bb5bf3))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants