fix: set Explore defaults on app load #2268
Conversation
|
note that we need to update ipld-explorer-components to use ╰─ ✘ 1 ❯ npm why @helia/block-brokers
@helia/[email protected]
node_modules/@helia/block-brokers
@helia/block-brokers@"^3.0.3" from @helia/[email protected]
node_modules/@helia/http
@helia/http@"^1.0.10" from [email protected]
node_modules/ipld-explorer-components
ipld-explorer-components@"^7.0.2" from the root project
@helia/block-brokers@"^3.0.3" from [email protected]
node_modules/ipld-explorer-components
ipld-explorer-components@"^7.0.2" from the root project |
| @@ -32,6 +33,11 @@ export class App extends Component { | |||
| isOver: PropTypes.bool.isRequired | |||
| } | |||
|
|
|||
| constructor (props) { | |||
| super(props) | |||
| props.doSetupLocalStorage() | |||
There was a problem hiding this comment.
This does not seem to work on initial page load.
If you use empty browser profile and load webui, and then go to ipld explorer and click on wikipedia example you will see spinner forever, and no request:
If you then force-reload the page (F5) the helia will initialize with local gateway and work fine:
There was a problem hiding this comment.
I think landing directly on explore page might cause the issue?
Issue doesn't happen if you land on status page first
There was a problem hiding this comment.
Might need to call the localStorage fn in router / component loader
There was a problem hiding this comment.
landing directly on explore page works for me with the latest.
2024-09-24.at.9.53.41.-.Blue.Bobolink.mp4
There was a problem hiding this comment.
Yep, that was it. New version works fine.
ps. TIL Firefox does not support HEVC while it is encumbered by patents, so inline player does not work (but i played fine with external player):
|
@lidel try now, it should work now that we're explicitly using [email protected] I believe you tested this after I committed |
| @@ -32,6 +33,11 @@ export class App extends Component { | |||
| isOver: PropTypes.bool.isRequired | |||
| } | |||
|
|
|||
| constructor (props) { | |||
| super(props) | |||
| props.doSetupLocalStorage() | |||
There was a problem hiding this comment.
landing directly on explore page works for me with the latest.
2024-09-24.at.9.53.41.-.Blue.Bobolink.mp4
SgtPooki
deleted the
2266-explore-page-stop-sending-requests-to-remote-http-servers
branch
## [4.3.2](v4.3.1...v4.3.2) (2024-09-24) CID `bafybeif6abowqcavbkz243biyh7pde7ick5kkwwytrh7pd2hkbtuqysjxy` --- ### Bug Fixes * set Explore defaults on app load ([#2268](#2268)) ([fd8819e](fd8819e)) * **ui:** replace IPFS API with Kubo RPC ([#2267](#2267)) ([f8ac305](f8ac305)) ### Trivial Changes * pull new translations ([#2264](#2264)) ([cfaf534](cfaf534))
|
🎉 This PR is included in version 4.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fix: set Explore defaults on app load