This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just banged up a quick async/await translation of the js-datastore-fs. I tried to follow ipfs/interface-datastore#25 for guidance. Let me know if this seems right. 3 test fail in this, I believe due to the dependency on datastore core.
I will probably tackle translating that next and then sync the js-ipfs-repo/js-datastore-fs PR's so all test pass.
One thing to note here is that within test, there is a linting error on for await ( x of asyncgenerator){} , which seems spurious, but I might be mistaken here, so if you have insight much appreciated, as well as any comments or corrections. I'm happy to dig in and clean it up!