Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade dependencies, use strict and fix /blocks pathing #29

Merged
merged 2 commits into from
Mar 20, 2016

Conversation

dignifiedquire
Copy link
Member

For @nginnever :)

@daviddias
Copy link
Member

what was the pathing issue?

const PREFIX_LENGTH = 8

exports = module.exports

exports.setUp = (basePath, blobStore, locks) => {
var store = blobStore(basePath + '/blocks')
const store = blobStore(basePath + '/blocks')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was here, in the version that was installed from npm, looks like I didn't fix it but the fix is not yet released to npm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it said before /blocks/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, could you explain a bit more please? btw, travis is failing

@daviddias
Copy link
Member

@dignifiedquire I'm still unaware of what was the bug this PR is fixing and what is the actual solution. Maybe @nginnever knows the answer? (travis tests are still failing)

@dignifiedquire
Copy link
Member Author

Sorry will explain tomorrow

@dignifiedquire
Copy link
Member Author

@diasdavid the most important fix is adding 'use strict' to all files, as the combination of non strict mode with some es6 features like const inside some browsers resulted in unpredictable behaviour when not transpiled through babel. (Remember those random tests failing for @nginnever, that was the reason for that)

The other issue was that in an older revision the repo path for the blocks was /blocks/ but in newer revisions it is /blocks. But that was fixed before this PR, but wasn't published to npm.

The tests also run in PhantomJS now to ensure things work
in older browsers.
@daviddias
Copy link
Member

Thank you @dignifiedquire . Also good discussion on the call today @dignifiedquire @nginnever :)

daviddias added a commit that referenced this pull request Mar 20, 2016
fix: Upgrade dependencies, use strict and fix /blocks pathing
@daviddias daviddias merged commit c2eb0d2 into master Mar 20, 2016
@daviddias daviddias deleted the fixes branch March 20, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants