chore: update types #302
Merged
chore: update types #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates deps - Changes Blockstore.query return type based on query arg - Exports Blockstore type from index.js - Moves Config types from ipfs-core-types to ipfs-repo - Removes bignumber.js dep in favour of using `BigInt`s - Normalises type import style - Removes ts-ignores from modules with types
vasco-santos
approved these changes
Apr 15, 2021
| getAll (options = {}) { // eslint-disable-line require-await | ||
| return configStore.get(undefined, options) | ||
| async getAll (options = {}) { // eslint-disable-line require-await | ||
| // [email protected] cannot read keys from [email protected] dbs so fall back to |
There was a problem hiding this comment.
Is there an issue to track this? If not, can you create one?
There was a problem hiding this comment.
I can do, but it's not something that's ever going to be fixed so the issue will hang around forever.
The level-js 4 -> 5 version bump was because of this breaking change.
There was a problem hiding this comment.
ok makes sense, so maybe not worth
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigInts