-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap with directory option with uint8array data returns empty root CID #176
Comments
My preference would be to remove the Failing that, this should probably throw an error as otherwise we have to guess what the filename of the content should be inside the directory. We could use the CID of the content but that's hard for the user to predict ahead of time. |
Yeah, I think this would remove "magic" from the user and is a good call. |
Code snipped replicating the issue:
The expectation would be to either throw an error or wrap with a directory. From my debugging, it looks that the underlying reason for this is that a path is not provided and unixfs-importer will not be able to properly wrap with a directory. We can make this work with:
We should either just thrown an error in such cases, or have a path inferred. @achingbrain what do you think to be the expectation here?
Related to storacha/ipfs-car#88
The text was updated successfully, but these errors were encountered: