refactor: use streaming for cli refs and refs local

ipfs · May 13, 2019 · 090a2f8 · 090a2f8
1 parent 29112bb
commit 090a2f8
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 16 deletions.
diff --git a/src/cli/commands/refs-local.js b/src/cli/commands/refs-local.js
@@ -10,14 +10,21 @@ module.exports = {
  handler ({ getIpfs, resolve }) {
  resolve((async () => {
  const ipfs = await getIpfs()
- const refs = await ipfs.refs.local()
- for (const ref of refs) {
- if (ref.err) {
- print(ref.err, true, true)
- } else {
- print(ref.ref)
- }
- }
+
+ return new Promise((resolve, reject) => {
+ const stream = ipfs.refs.localReadableStream()
+
+ stream.on('error', reject)
+ stream.on('end', resolve)
+
+ stream.on('data', (ref) => {
+ if (ref.err) {
+ print(ref.err, true, true)
+ } else {
+ print(ref.ref)
+ }
+ })
+ })
  })())
  }
 }
diff --git a/src/cli/commands/refs.js b/src/cli/commands/refs.js
@@ -45,14 +45,21 @@ module.exports = {
 
  const ipfs = await getIpfs()
  const k = [key].concat(keys)
- const refs = await ipfs.refs(k, { recursive, format, edges, unique, maxDepth })
- for (const ref of refs) {
- if (ref.err) {
- print(ref.err, true, true)
- } else {
- print(ref.ref)
- }
- }
+
+ return new Promise((resolve, reject) => {
+ const stream = ipfs.refsReadableStream(k, { recursive, format, edges, unique, maxDepth })
+
+ stream.on('error', reject)
+ stream.on('end', resolve)
+
+ stream.on('data', (ref) => {
+ if (ref.err) {
+ print(ref.err, true, true)
+ } else {
+ print(ref.ref)
+ }
+ })
+ })
  })())
  }
 }