Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

repo doesn't persist in browser on upgrade from v0.38.1 to v0.39.0 #2629

Closed
npfoss opened this issue Nov 24, 2019 · 3 comments
Closed

repo doesn't persist in browser on upgrade from v0.38.1 to v0.39.0 #2629

npfoss opened this issue Nov 24, 2019 · 3 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@npfoss
Copy link
Contributor

npfoss commented Nov 24, 2019 •
edited
Loading

  • Version: js-ipfs 0.38.1 and 0.39.0
  • Platform: latest Firefox and Brave (Chromium)
  • Subsystem: js-ipfs

Type: Bug

Severity: high

Description:

default repo doesn't persist in browser when you upgrade from v0.38.1 to v0.39.0

this is a big problem for serverless apps where the browser is the only place user data is stored :P

Steps to reproduce the error:

clone this repo and follow the simple three step readme: https:/npfoss/js-ipfs-bug-2
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP status/ready Ready to be worked labels Nov 25, 2019
@alanshaw
Copy link
Member

Screenshot 2019-11-25 at 09 16 29

Looks like between the two versions the level datastores gained a "level-js-" prefix.

@achingbrain do you have a sec to look into this?

@achingbrain
Copy link
Member

achingbrain commented Nov 25, 2019 •
edited
Loading

The defaults passed to level-js changed with the upgrade to level so a few changes need to be made:

@achingbrain achingbrain mentioned this issue Nov 29, 2019
Merged
2 tasks
achingbrain added a commit that referenced this issue Nov 29, 2019
@achingbrain
fix: requires the ipfs-repo version with a fix for #2629 at a minimum
5a86fe8 
Fixes #2629 and restores access to pre-0.39.0 repos though any repos
created with 0.39.0 will not be accessible by default.
@achingbrain achingbrain mentioned this issue Nov 29, 2019
Merged
achingbrain added a commit that referenced this issue Dec 2, 2019
@achingbrain
fix: requires the ipfs-repo version with a fix for #2629 at a minimum (…
d754abe 
…#2643)

Fixes #2629 and restores access to pre-0.39.0 repos though any repos
created with 0.39.0 will not be accessible by default.
@alanshaw
Copy link
Member

alanshaw commented Dec 2, 2019

fixed in 0.39.1 and 0.40.0

@alanshaw alanshaw closed this as completed Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alanshaw @achingbrain @npfoss