Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feature/files add #67

Merged
merged 1 commit into from
Mar 21, 2016
Merged

feature/files add #67

merged 1 commit into from
Mar 21, 2016

Conversation

daviddias
Copy link
Member

This PR adds files add and files add -r

Missing:

  • tests
  • figure out why adding a dir with multiple files is calling the success callback for each of those files (might be a bug with data-importing itself)

@RichardLitt
Copy link
Member

@diasdavid Would this need this issue to be solved? ipfs-inactive/http-api-spec#57

@daviddias
Copy link
Member Author

Yes, that would be 🌟

@daviddias daviddias mentioned this pull request Feb 23, 2016
14 tasks
@daviddias daviddias force-pushed the feature/files-add branch 3 times, most recently from 4faa8a9 to 8583416 Compare March 21, 2016 13:02
@daviddias
Copy link
Member Author

I'm going to merge this PR to unlock jsipfs init which needed files add for its base docs.

daviddias added a commit that referenced this pull request Mar 21, 2016
@daviddias daviddias merged commit 8e12e67 into master Mar 21, 2016
@daviddias daviddias deleted the feature/files-add branch March 21, 2016 13:13
This was referenced Mar 21, 2016
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
IPFS is all `dag-pb` yet we allow passing `dag-cbor` as the format of IPLD node to use.  This is likely to break anything that uses it as tools expect IPFS stuff to be `dag-pb`, possibly with `raw` leaves.

Closes ipfs#67

BREAKING CHANGE:

`--format` and/or `--codec` option has been removed from the CLI, the HTTP API and the core API.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants