feat(breaking change): experimental config options #749
Conversation
| @@ -0,0 +1,18 @@ | |||
| exports.goOnline = require('./go-online') | |||
There was a problem hiding this comment.
let's not duplicate exports everywhere
module.exports = {
goOnline: require('./go-online'),
...
}There was a problem hiding this comment.
Yeah, that way we have to worry about those commas, the way it is right now doesn't
There was a problem hiding this comment.
Not sure what commas you mean
There was a problem hiding this comment.
if it is inside an object, for every add/delete, we get the 'no dangling comma situation'
There was a problem hiding this comment.
we have a lot of mixed and unclean diffs, not sure this makes any diff ;)
| const node = new IPFS(repo) | ||
| const node = new IPFS({ | ||
| repo: repo, | ||
| EXPERIMENTAL: { |
There was a problem hiding this comment.
Do we have to upcase this? I think experimental is enough. What would be good is to print something to the console when this is enabled.
There was a problem hiding this comment.
I like making things very OBVIOUS :D
There was a problem hiding this comment.
BUT DO YOU REALLY NEED TO SCREAM AT ME?
daviddias
force-pushed
the
feat/put-experimental-behind-experimental
branch
from
a533bee
to
7ffcaf6
Compare
As recommended by @whyrusleeping, we need to pubsub behind a
EXPERIMENTALoption in the config options.Adding config options will cause a breaking cause in the API of creating a node, but it was a step we were going to make for #556 anyway.