This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
All new way of initing a node. #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all tests passing, now just have to update all the docs and tests wooo |
src/core/index.js
Outdated
| } | ||
|
|
||
| if (!( | ||
| typeof options.start === 'boolean' && |
daviddias
commented
Mar 15, 2017
| // node is now 'offline' | ||
| }) | ||
| }) | ||
| ``` |
There was a problem hiding this comment.
This has to make people happier :)
daviddias
commented
Mar 15, 2017
| Swarm: [ | ||
| '/ip4/127.0.0.1/tcp/1337' | ||
| ] | ||
| } |
There was a problem hiding this comment.
No more get/set config madness :)
|
Can I get some review now? :) |
daviddias
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ipfs-inactive/docs#22