Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass config to ipfs for proc daemon #268

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

jacobheun
Copy link
Contributor

config was not being passed to the IPFS instance when using the proc daemon. This would make it difficult to prevent an in process js daemon from automatically bootstrapping to discovery servers (the default IPFS behavior).

I am currently using this to test the private network addition to js-ipfs and want to avoid auto connecting to public networks.

@ghost ghost assigned jacobheun Jun 13, 2018
@ghost ghost added the status/in-progress In progress label Jun 13, 2018
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

License: MIT
Signed-off-by: Jacob Heun <[email protected]>
@ghost ghost assigned vasco-santos Jun 20, 2018
@vasco-santos vasco-santos merged commit 1cdb739 into master Jun 20, 2018
@ghost ghost removed the status/in-progress In progress label Jun 20, 2018
@hugomrdias hugomrdias deleted the fix/proc-config branch October 15, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants