Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawn non-disposable with init: true start: true doesn't work #305

Closed
hugomrdias opened this issue Oct 24, 2018 · 0 comments · Fixed by #379 · May be fixed by ajesse11x/ipfs-desktop#2 or ajesse11x/ipfs-desktop#4
Closed

spawn non-disposable with init: true start: true doesn't work #305

hugomrdias opened this issue Oct 24, 2018 · 0 comments · Fixed by #379 · May be fixed by ajesse11x/ipfs-desktop#2 or ajesse11x/ipfs-desktop#4
Assignees
@hugomrdias
Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/in-progress In progress

Comments

@hugomrdias
Copy link
Member

Check this #304
@hugomrdias hugomrdias added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP labels Oct 24, 2018
@hugomrdias hugomrdias self-assigned this Oct 24, 2018
@daviddias daviddias added the status/in-progress In progress label Oct 27, 2018
@hugomrdias hugomrdias mentioned this issue Oct 29, 2018
Closed
@daviddias daviddias added P1 High: Likely tackled by core team if no one steps up and removed P0 Critical: Tackled by core team ASAP labels Nov 14, 2018
hugomrdias added a commit that referenced this issue Sep 17, 2019
@hugomrdias
fix: fix non-disposable and normalise behaviour
f95d011 
closes #305
closes #276
closes #354
closes #330
closes #329
@hugomrdias hugomrdias mentioned this issue Sep 17, 2019
Merged
hugomrdias added a commit that referenced this issue Sep 17, 2019
@hugomrdias
fix: fix non-disposable and normalise behaviour
6be1a2b 
closes #305
closes #276
closes #354
closes #330
closes #329
hugomrdias added a commit that referenced this issue Sep 18, 2019
@hugomrdias
fix: fix non-disposable and normalises behaviour (#379)
b502bd4 
This PR reworks daemon spawn options and handling of start/init, it also makes sure spawned daemons attach themselves to running daemons on the default/provided repo.
Some dependencies were also removed.

closes #305
closes #276
closes #354
closes #330
closes #329
This was referenced Oct 27, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugomrdias hugomrdias

Labels
exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Milestone
No milestone
2 participants
@hugomrdias @daviddias