refactor: remove path and ref from module args also findBin #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're not passing modules to `.spawn()` there's no danger of passing module refs over http, so we can remove the `.path` and `.ref` arguments when specifying which `ipfs-http-client` and `ipfs` modules to use, instead setting them up when you configure the daemon factory, either in-proc or as a server in an `.aegir` file. Also removes the `findBin` command magic in favour of being explicit about which binary you want the factory to use. If you need to support env vars like `IPFS_GO_EXEC`, do that when you set up the factory. BREAKING CHANGES: - `.path` and `.ref` args removed from `ipfsModule` and `ipfsHttpModule` - `findBin` function removed
achingbrain
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're not passing modules to
.spawn()there's no danger of passing module refs over http, so we can remove the.pathand.refarguments when specifying whichipfs-http-clientandipfsmodules to use, instead setting them up when you configure the daemon factory, either in-proc or as a server in an.aegirfile.Also removes the
findBincommand magic in favour of being explicit about which binary you want the factory to use.If you need to support env vars like
IPFS_GO_EXEC, do that when you set up the factory, for example:Also fixes up the examples and upgrades the
ipfsdep to run tests against the async/await refactor.BREAKING CHANGES:
.pathand.refargs removed fromipfsModuleandipfsHttpModulefindBinfunction removed