Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use .create function for http client and ipfs client #616

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

achingbrain
Copy link
Member

ipfs/js-ipfs#3550 switches away from default exports for ipfs-http-client
and ipfs-client to enable an easier transition to es6 modules.

All ipfs modules now export a .create factory function which returns
instances of the client module.

BREAKING CHANGE: expects ipfs-http-client and ipfs-client to export a .create function

ipfs/js-ipfs#3550 switches away from default exports for `ipfs-http-client`
and `ipfs-client` to enable an easier transition to es6 modules.

All `ipfs` modules now export a `.create` factory function which returns
instances of the client module.

BREAKING CHANGE: expects `ipfs-http-client` and `ipfs-client` to export a `.create` function
@achingbrain
Copy link
Member Author

This PR needs ipfs/js-ipfs#3550 for the build to pass due to the ipfs-http-client exports change, which needs this PR for it's build to pass. I'm going to merge this an release as a major, then we can circle back here once ipfs/js-ipfs#3550 is shipped.

@achingbrain achingbrain merged commit d2f623a into master Mar 26, 2021
@achingbrain achingbrain deleted the chore/switch-to-create-for-http-client branch March 26, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants