Garbage collection doesn't free up space when using badger

[leerspace]

Version information:

go-ipfs version: 0.4.11-
Repo version: 6
System version: amd64/linux
Golang version: go1.9

Type:

Bug

Severity:

Medium/High

Description:

When running garbage collection on a repo using the badger datastore, local storage is not freed up after running ipfs repo gc.

[Stebalien]

Yeah, that's because badger has to do a separate internal GC. Currently, we don't manually trigger it on repo GC but we probably should.

[leerspace]

It looks like this might have been "fixed" by ipfs/go-datastore#68 and the "Basic GC Implementation" commit to go-ds-badger (?). Should this work already or do the changes to go-ds-badger just need to bubble up?

[magik6k]

The changes are bubbled up, just not wired up to gc logic

[magik6k]

#4578 is going to fix this, at least for big datastores (few gigs with with 100s of MBs of reclaimable space).

For full GC there is an offline tool being developed in dgraph-io/badger#400, which will likely help with the cases where the online badger GC doesn't help

[schomatis]

#4578 has been merged and the GC logic is working, note however that the GC mechanism for badger is not the same as for flatfs, some space may not be immediately reclaimed.