Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion doesn't complete files with spaces #8033

Closed
bam80 opened this issue Mar 28, 2021 · 1 comment · Fixed by #8043
Closed

bash completion doesn't complete files with spaces #8033

bam80 opened this issue Mar 28, 2021 · 1 comment · Fixed by #8043
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@bam80
Copy link

bam80 commented Mar 28, 2021

Here is an example:

bam@Feedme:~$ ipfs files ls /
Pictures
bam@Feedme:~$ ipfs files ls /Pictures/Screenshot 
Error: file does not exist
# <Tab> was pressed several times, no more completion here ^
bam@Feedme:~$ ipfs files ls /Pictures/
Screenshot from 2020-09-15 23-31-28.png
# and here is the actual file name with spaces

@EliasGabrielsson

@bam80 bam80 added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Mar 28, 2021
@welcome
Copy link

welcome bot commented Mar 28, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

Stebalien added a commit that referenced this issue Apr 1, 2021
These are missing some of the features of the current hand-rolled
completions, but:

1. Are less buggy.
2. Cover _all_ commands.
3. Don't need to be manually maintained (which we never do anyways).

fixes #4551
fixes #8033
Stebalien added a commit that referenced this issue Apr 1, 2021
These are missing some of the features of the current hand-rolled
completions, but:

1. Are less buggy.
2. Cover _all_ commands.
3. Don't need to be manually maintained (which we never do anyways).

fixes #4551
fixes #8033
Stebalien added a commit that referenced this issue Apr 1, 2021
These are missing some of the features of the current hand-rolled
completions, but:

1. Are less buggy.
2. Cover _all_ commands.
3. Don't need to be manually maintained (which we never do anyways).

fixes #4551
fixes #8033
Stebalien added a commit that referenced this issue Jul 1, 2021
These are missing some of the features of the current hand-rolled
completions, but:

1. Are less buggy.
2. Cover _all_ commands.
3. Don't need to be manually maintained (which we never do anyways).

fixes #4551
fixes #8033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant