Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): update gateway api, no multi-range support #10024

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jul 25, 2023

@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from c6d99b2 to 04dafd0 Compare July 25, 2023 10:43
@hacdias hacdias self-assigned this Jul 31, 2023
@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from 04dafd0 to 58fa0c7 Compare July 31, 2023 09:23
@hacdias hacdias requested a review from lidel July 31, 2023 09:25
@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from 428fade to bcc9a3b Compare July 31, 2023 11:22
@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Jul 31, 2023
@hacdias hacdias changed the title chore: bump boxo for boxo#369 [skip changelog] chore: bump for boxo#369 (more explicit backend api) Jul 31, 2023
@BigLep BigLep mentioned this pull request Aug 3, 2023
@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from 0f08d51 to 1fd57b6 Compare August 3, 2023 09:01
test/cli/gateway_range_test.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from 1fd57b6 to 5b78057 Compare August 7, 2023 07:52
@hacdias hacdias requested a review from lidel August 7, 2023 07:52
@hacdias hacdias marked this pull request as ready for review August 7, 2023 07:52
@hacdias hacdias requested a review from a team as a code owner August 7, 2023 07:52
@lidel
Copy link
Member

lidel commented Aug 10, 2023

Pushed ae6b113 with pinned conformance CI revision to double-check if unreleased 404 tests from ipfs/gateway-conformance#131 and ipfs/gateway-conformance#132 pass against this PR.
(Would be unfortunate if we realize 404s are broken after this PR is merged)

Will check result tomorrow.

@hacdias
Copy link
Member Author

hacdias commented Aug 10, 2023

@lidel seem to pass 😄

lidel
lidel previously requested changes Aug 10, 2023
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight concern on user data loss caused by CAR root change

Someone probably built things that depend on exporting CAR from gateway and then importing it to Kubo.

By removing the CAR root we introduce a surface for data loss, as exported full DAG is no longer pinned by default on `ipfs dag import.

We should double check if we change default behavior or not, and document what changed:

@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from 7c2aee0 to 7f4bed8 Compare August 11, 2023 12:59
@hacdias
Copy link
Member Author

hacdias commented Aug 11, 2023

@lidel

see if we keep useful root when we know

Please check my comment on that thread.

add/update changelog for Kubo 0.23.md and note when CAR responses no longer have a meaningful root explicitly listed in CARv1, but use bogus bafkqaaa as a placeholder (4XX/5XX errors only, or more?)

I added the information about what to expect.

@hacdias hacdias requested a review from lidel August 11, 2023 13:00
@hacdias hacdias removed the skip/changelog This change does NOT require a changelog entry label Aug 11, 2023
@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch 3 times, most recently from d5e2d57 to 10bc6cd Compare August 18, 2023 08:07
@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Aug 18, 2023
@hacdias hacdias changed the title chore: bump for boxo#369 (more explicit backend api) chore: update gateway api for more explicit version, no multirange Aug 18, 2023
@hacdias hacdias changed the title chore: update gateway api for more explicit version, no multirange chore: update gateway api, no multi-range support Aug 18, 2023
@hacdias hacdias force-pushed the feat/gateway-backend-more-explicit branch from 1e979ed to a3c45c0 Compare October 2, 2023 14:27
@hacdias hacdias changed the title chore: update gateway api, no multi-range support feat(gateway): update gateway api, no multi-range support Oct 2, 2023
@hacdias hacdias removed the skip/changelog This change does NOT require a changelog entry label Oct 2, 2023
@hacdias hacdias merged commit 9752747 into master Oct 2, 2023
20 checks passed
@hacdias hacdias deleted the feat/gateway-backend-more-explicit branch October 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants