refactor: namesys cleanup, gateway /ipns/ ttl #10115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hacdias
force-pushed
the
path-consolidation
branch
from
d9bca2c
to
8eb565d
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
8eb565d
to
6609a24
Compare
hacdias
force-pushed
the
path-consolidation
branch
2 times, most recently
from
6338df4
to
f5b4175
Compare
hacdias
force-pushed
the
ns-cleanup
branch
2 times, most recently
from
7c1a4ed
to
19e5f0e
Compare
hacdias
force-pushed
the
path-consolidation
branch
2 times, most recently
from
77ea675
to
4b18d58
Compare
hacdias
force-pushed
the
path-consolidation
branch
3 times, most recently
from
f78a7ee
to
21d1144
Compare
hacdias
force-pushed
the
ns-cleanup
branch
4 times, most recently
from
cf4c980
to
4007649
Compare
hacdias
force-pushed
the
path-consolidation
branch
4 times, most recently
from
297c4bb
to
9e7452e
Compare
hacdias
force-pushed
the
path-consolidation
branch
from
9e7452e
to
8017256
Compare
lidel
approved these changes
Oct 10, 2023
lidel
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Pushed some changes from ipfs/boxo#459, mainly the changelog and wiring up the updated IPNS defaults that are now clearly defined in boxo/namesys.
@hacdias We need a basic test for gateway (detail inline), but other than that lgtm.
Basic UX improvement that makes helptext up-to-date and more useful.
The TTL is not optional: https://specs.ipfs.tech/ipns/ipns-record/#ipns-record and it is better to clearly state what is the implicit default, rather than hide it from user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/ipnspaths andCache-ControlHTTP header gateway-conformance#173